i18n(ja): unify columnar terminology to a single term - #23634
Conversation
Unifies 4 competing renderings of "columnar" into the dominant term 列指向: カラム型 (22 genuine occurrences, excluding 1 false-friend "column type" usage in releases/release-8.5.7.md left untouched), 列ベース (19, all paired with 行ベース "row-based" contrastively — matches EN's own asymmetric "row-based"/"columnar" root pairing, not a JA-only symmetry worth preserving), カラムナー (2), and 列形式 (2 genuine "columnar format" sentences out of 8 raw hits — the other 6 were 文字列形式/配列形式/オブジェクト形式 "string/array/object format" false positives from a substring match, left untouched). 27 files, 45 sites.
ti-chi-bot
Bot
added
area/develop
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ti-chi-bot
Bot
added
the
size/M
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe Japanese documentation updates TiFlash and columnar-storage terminology from older expressions to 「列指向」 across core, TiDB Cloud, and release documents. Links, anchors, metric identifiers, version values, and functional content remain unchanged. ChangesTiFlash terminology updates
Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: ⚪ Minimal · up to This PR standardizes Japanese documentation terminology without changing product behavior, and no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) Full details: Description checkExplanation The description covers the required change summary, affected version, AI involvement, scope decisions, and verification method. The related-link fields are blank, but they are non-critical and the description is otherwise complete. ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The previous commit generalized too broadly. Re-checked EN wording at every converted site individually: 6 of them literally say "column-based" (paired with "row-based" as a matched contrastive pair, e.g. dev-guide-create-table.md's "TiKV (row-based) or TiFlash (column-based)"), not "columnar". Since this is a translation, each site should mirror EN's own actual word choice rather than a single normalized house term.
1 participant
What is changed, added or deleted? (Required)
Unifies Japanese renderings of the storage-architecture concept "columnar" to a single term, following the direction already decided in a prior term-notation review. Each EN term maps 1:1 to one JA term — no two distinct EN words were collapsed into the same JA term (see the mapping table below).
EN → JA mapping (before / after)
releases/release-8.5.7.md)JSON"). Left untouched.27 files, 39 sites converted to 列指向.
Method / verification
Every site that had a candidate rendering was checked individually against its own exact EN sentence (not inferred from a handful of samples) before being converted or left alone — a first pass generalized "列ベース always means columnar" from a few examples and wrongly converted 6 "column-based" sites; caught and reverted after re-checking each of the 19 列ベース sites' actual EN wording one by one.
Also excluded, verified as unrelated substring matches, not "columnar": 6 of 8 raw
列形式hits (文字列形式/配列形式/オブジェクト形式— "string/array/object format").Verified
markdownlint-cli2clean on all touched files.Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?